Too much parsing, exploding, regex, strcmp, strpos and string manipulation functions.
TL;DR: Use real abstractions and real objects instead of accidental string manipulation.
Problems 😔
- Complexity
- Readability
- Maintainability
- Lack of abstractions
- Fragile logic
- Hidden intent
- Hard debugging
- Poor modeling
- Regex mess
Solutions 😃
- Work with objects instead.
- Replace strings with data structures dealing with object relations.
- Go back to Perl :)
- identify bijection problems between real objects and the strings.
Examples
- Serializers
- Parsers
Context 💬
When you abuse strings, you try to represent structured concepts with plain text.
You parse, explode, and regex your way around instead of modeling the domain.
This creates fragile code that breaks with small input changes.
Sample Code 📖
Wrong 🚫
<?php
$schoolDescription = 'College of Springfield';
preg_match('/[^ ]*$/', $schoolDescription, $results);
$location = $results[0]; // $location = 'Springfield'.
$school = preg_split('/[\s,]+/', $schoolDescription, 3)[0];
//'College'
Right 👉
<?
class School {
private $name;
private $location;
function description() {
return $this->name . ' of ' . $this->location->name;
}
}
Detection 🔍
- Semi-Automatic
Automated detection is not easy.
If your code uses too many string functions, linters can trigger a warning.
Tags 🏷️
- Primitive Obsession
Level 🔋
- Beginner
Why the Bijection Is Important 🗺️
You must mirror the real-world domain in your code.
When you flatten roles, addresses, or money into raw strings, you lose control.
This mismatch leads to errors, duplication, and weak models.
One-to-one mapping between domain and code gives you clarity and robustness.
AI Generation 🤖
AI generators often produce string-abusing code because it looks shorter and easier.
The generated solution can be correct for toy cases but fragile in real systems.
AI Detection 🧲
You can instruct AI tools to replace string checks with domain objects.
With clear prompts, AI can spot and fix string abuse effectively.
Try Them! 🛠
Remember: AI Assistants make lots of mistakes
Suggested Prompt: Convert it to more declarative
|
Without Proper Instructions |
With Specific Instructions |
|---|---|
Conclusion 🏁
Don't abuse strings.
Favor real objects.
Add missing protocol to distinguish them from raw strings.
Relations 👩❤️💋👨
https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxv
https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxv
https://maximilianocontieri.com/code-smell-295-string-concatenation?embedable=true
More Information 📕
Credits 🙏
Photo by Nathaniel Shuman on Unsplash
This article is part of the CodeSmell Series.
https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-i-xqz3evd?embedable=true
[story continues]
tags